Skip to content

Conversation

biscout42
Copy link
Contributor

@biscout42 biscout42 commented Aug 19, 2025

This PR fixes namespace usage in synthetic monitors. It separates Kibana space_id the monitor is saved in from the namespace, the data stream namespace for Fleet.

In addition:

@biscout42 biscout42 marked this pull request as ready for review August 19, 2025 15:57
@tobio
Copy link
Member

tobio commented Aug 20, 2025

This duplicates #1208

@biscout42
Copy link
Contributor Author

@tobio , sorry, I missed the original PR. Feel free to close this if it doesn't help. Most important to have functionality work.

@biscout42
Copy link
Contributor Author

re-running failed due-to

read tcp 10.1.0.62:40486->185.199.110.133:443: read: connection reset by peer

tobio
tobio previously approved these changes Aug 26, 2025
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@biscout42
Copy link
Contributor Author

Thanks, @tobio . To summarise our discussion about keeping TF provider logic (#1208) for setting namespace value vs kibana defaults (this PR).

  • for already created monitors via TF provider imho there is no difference. After TF provider upgrade it will use value from kibana due-to UseStateForUnknown() and it will be the value we did set based on space_id.
  • for new monitors we agreed default to kibana value. The assumption here is: it should not affect most of the end users, because a user doesn't interact with sythetic datastreams directly. Taking into account upcoming changes in 9.1+, where synthetics and fleet policies are space aware, using kibana defaults will help us avoid confusions.

Added couple of more things:

  1. I have moved regex validation from Add namespace support to elasticstack_kibana_synthetics_monitor resource #1208 to this PR
  2. Allowed changing namespace, as kibana allows it (no resource replace anymore)

@biscout42 biscout42 enabled auto-merge (squash) August 26, 2025 13:50
@biscout42 biscout42 merged commit c9b6a6b into elastic:main Aug 27, 2025
23 checks passed
tobio added a commit that referenced this pull request Sep 2, 2025
* origin/main:
  Migrate Elasticsearch enrich policy resource and data source to Terraform Plugin Framework (#1220)
  Add support for solution field in elasticsearch_kibana_space resource and data source (#1210)
  Don't force replacement when changing integration versions (#1255)
  chore(deps): update golang:1.25.0 docker digest to 5502b0e (#1267)
  chore(deps): update docker.elastic.co/kibana/kibana docker tag to v9.1.3 (#1263)
  Bump github.com/ulikunitz/xz from 0.5.12 to 0.5.14 (#1264)
  Migrate Kibana connectors to use the bundled openapi generated client (#1260)
  Extend CONTRIBUTING.md (#1262)
  fix: add `namespace` attribute to `elasticstack_kibana_synthetics_monitor` resource (#1247)
  Bump github.com/stretchr/testify from 1.10.0 to 1.11.0 (#1261)
  chore(deps): update codecov/codecov-action digest to fdcc847 (#1258)
  fix(deps): update module go.uber.org/mock to v0.6.0 (#1259)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants