-
Notifications
You must be signed in to change notification settings - Fork 116
fix: make synthetics
fleet namespace aware
#1247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This duplicates #1208 |
@tobio , sorry, I missed the original PR. Feel free to close this if it doesn't help. Most important to have functionality work. |
re-running failed due-to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks, @tobio . To summarise our discussion about keeping TF provider logic (#1208) for setting namespace value vs kibana defaults (this PR).
Added couple of more things:
|
* origin/main: Migrate Elasticsearch enrich policy resource and data source to Terraform Plugin Framework (#1220) Add support for solution field in elasticsearch_kibana_space resource and data source (#1210) Don't force replacement when changing integration versions (#1255) chore(deps): update golang:1.25.0 docker digest to 5502b0e (#1267) chore(deps): update docker.elastic.co/kibana/kibana docker tag to v9.1.3 (#1263) Bump github.com/ulikunitz/xz from 0.5.12 to 0.5.14 (#1264) Migrate Kibana connectors to use the bundled openapi generated client (#1260) Extend CONTRIBUTING.md (#1262) fix: add `namespace` attribute to `elasticstack_kibana_synthetics_monitor` resource (#1247) Bump github.com/stretchr/testify from 1.10.0 to 1.11.0 (#1261) chore(deps): update codecov/codecov-action digest to fdcc847 (#1258) fix(deps): update module go.uber.org/mock to v0.6.0 (#1259)
This PR fixes
namespace
usage in synthetic monitors. It separates Kibanaspace_id
the monitor is saved in from thenamespace
, the data stream namespace for Fleet.In addition:
9.x
, related to Remove Dashboard Import/Export API kibana#414399.1
has fleet policy namespace aware.